Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip should not reopen when target element is not hovered anymore #1074

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Apr 19, 2024

Done

  • tooltip should not reopen when target element is not hovered anymore. Tooltip was running multiple timers in the background, that would reopen it after it was closed.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: #1073

@webteam-app
Copy link

@lorumic
Copy link
Contributor

lorumic commented Apr 19, 2024

QA steps

  • hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

This is not clear to me. Can you add a before/after screen capture that shows how to QA?

@edlerd
Copy link
Contributor Author

edlerd commented Apr 19, 2024

QA steps

  • hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

This is not clear to me. Can you add a before/after screen capture that shows how to QA?

Before
Screencast from 19.04.2024 10:40:59.webm

After
Screencast from 19.04.2024 10:40:23.webm

@lorumic
Copy link
Contributor

lorumic commented Apr 19, 2024

Checked out the branch and tested locally. The issue seems to still happen.

Peek.2024-04-19.12-29.webm

…more. fixes #1073

Signed-off-by: David Edler <david.edler@canonical.com>
@lorumic lorumic merged commit 3de71fc into main Apr 19, 2024
11 of 14 checks passed
@lorumic lorumic deleted the avoid-tooltip-reopen branch April 19, 2024 13:13
Copy link

🎉 This PR is included in version 0.51.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip does not disappear when hovering over another tooltip in the same component
3 participants